cross-posted from: https://lemmynsfw.com/post/14637170

Also, are there Lemmy frontends that don’t screw up the order of uploads? The perfectionist in me just screams, but doing it one by one is blah.

Should I even be posting albums in the first place? I sorta like the curation aspect more than just firing off individual pictures, but I don’t know how the audience feels about this 😁 Feedback welcome!

  • demonologicOP
    1•4 months ago

    Honestly could be, it’s been a while since I had to touch web UI code. I had a vague memory that at least in Firefox and Chrome file pickers give their resulting FileList in the same order as the files were in the native picker dialog. My gut feeling is that there’s a for … of loop somewhere in lemmy-ui that goes through the file list returned by the picker, and starts an upload for each file so that each upload’s completion handler adds the newly-minted image’s markdown to the comment. It really does feel like the order is based on whichever upload finishes first, because often the order is sort of correct but not quite.

    • @computerfucker
      1•4 months ago

      Yeah, that is correct. Firefox and chrome will return the order of the file picker. So unless you already sorted it in the file picker, the ui must somehow add an extra step before uploading as you cannot get the data of their selection order.

      If that was your case, then it is absolutely a bug that can be fixed on the client side without adding new features.

      • demonologicOP
        2•4 months ago

        Oh yes but my point is that even though I know that the order in the file picker is correct, the result often isn’t. Out of curiosity I just had to check how lemmy-ui does things, and turns out I was essentially right about how the uploads are done: looking at the markdown textarea source, each upload is turned into Markdown and added into the comment body as soon as it finishes (in uploadSingleImage). Wouldn’t even be all that hard of a fix I think, let’s see if I’ll find the energy to make a throwaway github account and make a PR out of this 😅

        • @computerfucker
          1•4 months ago

          Yeah, the problem is that concurrent image upload is splicing the array. That means there is a batch. Each “first” in their batch will be processed first leaving the actual 2nd image waiting for the actual 1st to be finished, but the 4th has begun uploading.

          Edit : Sorry, can’t really help writing code as I am on mobile but it is funny to think that actual development can take places anywhere for open source software.