• Psaldorn
      link
      fedilink
      332 months ago

      Merging failing tests so everybody else has failing tests and wastes time figuring out why.

      Nothing neutral here

      • @RamblingPanda
        link
        12 months ago

        That’s what the pipeline is for. It’s not that hard to pinpoint the commit that lead to the errors.

        • Psaldorn
          link
          fedilink
          82 months ago

          If I rebase my branch with main I do not expect any failing tests. If you waste my time merging shit code, fuck you. Fix your shit.

          Unless prod is on fire and the CEO is prowling (even then, I’d argue standards should be maintained)

          • @RamblingPanda
            link
            52 months ago

            I don’t say this is good practice, you shouldn’t even be able to merge to main with failing tests. I’ve implemented an emergency flag to do this, but I don’t want to use it in normal, daily business.