@[email protected] to Experienced [email protected]English • 1 day agoWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careersmessage-square14fedilinkarrow-up124
arrow-up124external-linkWhile reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do?cupid.careers@[email protected] to Experienced [email protected]English • 1 day agomessage-square14fedilink
minus-squareAlexlinkfedilink10•1 day agoThe link refers to it being a style in an area that isn’t covered. In that case I’d favour consistency with the current code it’s touching and open an issue to update the style guide to cover the new area.
The link refers to it being a style in an area that isn’t covered. In that case I’d favour consistency with the current code it’s touching and open an issue to update the style guide to cover the new area.